Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to route requests to sidecar container #270

Merged
merged 9 commits into from
Dec 30, 2024

Conversation

edorizzardi
Copy link
Contributor

Description

This PR changes the Service such that it allows to route requests to an arbitrary port. This is not a breaking change.

@dmotte
Copy link

dmotte commented Dec 16, 2024

@pierluigilenoci since you are the most active committer of this repo, may we kindly ask you if you could please take a look? Although quite simple, this fix would be very beneficial for us 🙂 thank you so much in advance!

@pierluigilenoci
Copy link
Contributor

@edorizzardi Please update the message for ArtifactHub and rebase the PR from the main branch. 🙏🏻 👍🏻

@edorizzardi
Copy link
Contributor Author

@pierluigilenoci thank you. Done

@pierluigilenoci
Copy link
Contributor

pierluigilenoci commented Dec 23, 2024

@edorizzardi The chart bump is now missing (this is a new feature, so it must be a "minor"). ➕
I also noticed that the option must be documented in the readme. 😬
https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/README.md

@edorizzardi
Copy link
Contributor Author

@pierluigilenoci Updated minor version. Plus I added the parameter in the list, and added a small paragraph on how to use my changes.

Copy link
Contributor

@pierluigilenoci pierluigilenoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some details to iron out, sorry if I'm being pedantic. 🙏🏻

helm/oauth2-proxy/README.md Outdated Show resolved Hide resolved
helm/oauth2-proxy/README.md Outdated Show resolved Hide resolved
helm/oauth2-proxy/values.yaml Outdated Show resolved Hide resolved
@pierluigilenoci pierluigilenoci merged commit 76e6b86 into oauth2-proxy:main Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants